Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GraphQL Java 19.2 #444

Closed
bclozel opened this issue Jul 20, 2022 · 1 comment
Closed

Upgrade to GraphQL Java 19.2 #444

bclozel opened this issue Jul 20, 2022 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jul 20, 2022

While working on reinstating the Spring for GraphQL auto-configuration in Spring Boot 3, I noticed a binary incompatibility when running tests:

Caused by: java.lang.NoClassDefFoundError: Could not initialize class graphql.parser.antlr.GraphqlLexer
	at graphql.parser.Parser.parseImpl(Parser.java:187)
	at graphql.parser.Parser.parseDocumentImpl(Parser.java:156)
	at graphql.parser.Parser.parseDocument(Parser.java:147)
	at graphql.schema.idl.SchemaParser.parseImpl(SchemaParser.java:122)

This happens because in Spring Boot 3, the Hibernate 6 dependency enforces an antlr4-run 4.10 version, while graphql-java relies on 4.9.x. See this dependency insight report. The antlr4 4.9 -> 4.10 upgrade is breaking backwards compatibility and all grammars need to be regenerated, this is described in the official release notes.

The GraphQL Java team already received this feedback and decided to shade the antlr dependency to avoid future issues.

This means that Spring for GraphQL 1.1.0 will require GraphQL Java 19 as a minimum requirement.

@bclozel bclozel added type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change labels Jul 20, 2022
@bclozel bclozel added this to the 1.1.0 milestone Jul 20, 2022
@bclozel bclozel self-assigned this Jul 20, 2022
@bclozel bclozel modified the milestones: 1.1.0, 1.1.0-M1 Jul 20, 2022
@bclozel bclozel closed this as completed in 40c354a Aug 1, 2022
@bclozel bclozel removed the status: blocked An issue that's blocked on an external project change label Aug 1, 2022
@bclozel
Copy link
Member Author

bclozel commented Aug 1, 2022

@bclozel bclozel reopened this Sep 8, 2022
@bclozel bclozel changed the title Upgrade to GraphQL Java 19.0 Upgrade to GraphQL Java 19.2 Sep 8, 2022
@bclozel bclozel closed this as completed in 3dd42b5 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant