Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade baseline to Java 17 and Jakarta APIs #426

Closed
bclozel opened this issue Jun 24, 2022 · 3 comments
Closed

Upgrade baseline to Java 17 and Jakarta APIs #426

bclozel opened this issue Jun 24, 2022 · 3 comments
Assignees
Labels
in: core Issues related to config and core support type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jun 24, 2022

Spring for GraphQL 1.1.0 will be released for Spring Boot 3.0 and Spring Framework 6.0.
As previously announced, this raises the baseline to Java 17 and Jakarta EE 9 APIs.

@bclozel bclozel added type: enhancement A general enhancement in: core Issues related to config and core support labels Jun 24, 2022
@bclozel bclozel added this to the 1.1.0-M1 milestone Jun 24, 2022
@bclozel bclozel self-assigned this Jun 24, 2022
@andrei-ivanov
Copy link

Wouldn't it be better to increase the major version for such changes?

@bclozel
Copy link
Member Author

bclozel commented Jun 27, 2022

Yes, this has been discussed a lot within the Spring for GraphQL team. A new major version would be indeed in line with the Spring team's policy.

But given the recent 1.0 release and the upcoming Spring Framework 6.0 and Spring Boot 3.0 releases, we were left with 3 choices:

  1. Cut a new 2.0 release only a few months after the 1.0, leaving us no room for important changes in the next years. At this point, the community is starting to adopt this project and we're collecting more and more feedback.
  2. Not release a Spring for GraphQL version compatible with Spring Boot 3.0 right away and waiting a few months until we feel ready to have a new major version. This would effectively leave a "support gap" for Spring Boot 2.7 users willing to upgrade to Spring Boot 3.0. Community was already asking for Spring Boot 3.0 plans.
  3. Cut a 1.1.0 release, just adapting to baseline requirements and not breaking APIs. We can then consider releasing a more ambitious 2.0 version during the lifetime of the Spring Boot 3.x generation, always balancing the upgrade experience with changes requested by the community

After discussing this matter with the Spring Framework and Spring Boot team, we chose 3).

@bclozel
Copy link
Member Author

bclozel commented Nov 22, 2022

This has been updated in 1.1.0 as a result of spring-projects/spring-framework#29435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues related to config and core support type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants