Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BindingResult error when ModelAttribute has custom name in WebFlux #28422

Conversation

bougar
Copy link
Contributor

@bougar bougar commented May 5, 2022

I guess this part of the code is trying to get the ModelAttribute annotation from the BindingResult parameter itself instead of the previous one as it should be. This is causing ann variable to be always null and therefore ignoring the value of the @ModelAttribute annotation.

@pivotal-cla
Copy link

@bougar Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@bougar Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 5, 2022
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label May 6, 2022
@sbrannen sbrannen self-assigned this May 6, 2022
@sbrannen sbrannen changed the title Fix BindingResult error when ModelAttribute has value in spring-flux Fix BindingResult error when ModelAttribute has value in spring-webflux May 6, 2022
@sbrannen sbrannen added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 6, 2022
@sbrannen sbrannen added this to the 5.3.20 milestone May 6, 2022
@sbrannen sbrannen changed the title Fix BindingResult error when ModelAttribute has value in spring-webflux Fix BindingResult error when ModelAttribute has custom name in spring-webflux May 6, 2022
@sbrannen sbrannen changed the title Fix BindingResult error when ModelAttribute has custom name in spring-webflux Fix BindingResult error when ModelAttribute has custom name in WebFlux May 7, 2022
sbrannen added a commit that referenced this pull request May 7, 2022
@sbrannen sbrannen closed this in 39e3876 May 7, 2022
@sbrannen
Copy link
Member

sbrannen commented May 7, 2022

Good catch!

This has been merged into 5.3.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants