Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LocalDataSourceJobStore only if one is not specified via Quartz properties #27560

Closed
wants to merge 3 commits into from
Closed

Use LocalDataSourceJobStore only if one is not specified via Quartz properties #27560

wants to merge 3 commits into from

Conversation

p-daniil
Copy link

@p-daniil p-daniil commented Oct 14, 2021 •
edited by sbrannen

Faced with the problem that I can't set my JobStore via quartz properties:
spring.quartz.properties.org.quartz.jobStore.class=org.quartz.impl.jdbcjobstore.JobStoreTX

Fixes

@pivotal-cla
Copy link

@p-daniil Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@p-daniil Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 14, 2021
@sbrannen
Copy link
Member

sbrannen commented Oct 19, 2021 •
edited

Hi @p-daniil,

Thanks for opening your first pull request for the Spring Framework!

Can you please introduce a test that fails before the change and passes afterwards?

@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) status: waiting-for-feedback We need additional information before we can continue labels Oct 19, 2021
@sbrannen sbrannen mentioned this pull request Oct 19, 2021
Closed
@p-daniil
Copy link
Author

Hi @sbrannen,
I have added test.
Without my fix it results with:

expected: org.quartz.impl.jdbcjobstore.JobStoreTX
 but was: org.springframework.scheduling.quartz.LocalDataSourceJobStore

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 19, 2021
@sbrannen
Copy link
Member

I have added test.

Thanks @p-daniil.

I'll look into it.

@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Oct 20, 2021
@sbrannen sbrannen self-assigned this Oct 20, 2021
@sbrannen sbrannen added this to the 5.3.13 milestone Oct 20, 2021
@sbrannen sbrannen changed the title Use LocalDataSourceJobStore only if not specified another one via quartz properties Use LocalDataSourceJobStore only if one is not specified via Quartz properties Oct 20, 2021
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Oct 23, 2021
@sbrannen
Update copyright date
2c89ff9 
See spring-projectsgh-27560
@sbrannen sbrannen closed this in c58853f Oct 23, 2021
@sbrannen
Copy link
Member

This has been merged into 5.3.x and main in c58853f.

Thanks

@sync-by-unito sync-by-unito bot mentioned this pull request Nov 11, 2021
Closed
@wilkinsona wilkinsona mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@p-daniil @pivotal-cla @sbrannen @spring-projects-issues