Fix infinite loop bug in AnnotationScanner #25429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yilianhuaixiao Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@yilianhuaixiao Thank you for signing the Contributor License Agreement! |
|
Have you encountered an exception or some form of infinite loop in your code regarding your proposed change? If so, please elaborate. In any case, please add a test to this PR that fails before the proposed change and passes after the proposed change. Thanks |
sbrannen
added
in: core
|
I add the testcase. |
|
@sbrannen Thanks for your advice |
spring-projects-issues
added
status: feedback-provided
Thanks! We'll look into it. |
|
Tentatively slated for 5.3 M2 for investigation. |
sbrannen
changed the title
sbrannen
added
type: bug
sbrannen
changed the title
sbrannen
added a commit
that referenced
this pull request
Jul 25, 2020
|
This has been merged into Thanks! @yilianhuaixiao, out of curiosity, since this code path is not executed in production code, how did you notice this bug? |
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Jul 25, 2020
PR spring-projectsgh-25429 brought it to our attention that there was a bug in AnnotationScanner when using a non-null class filter that filtered out classes; however, it turns out that there is no production code that utilizes the package-private class filtering support. This commit therefore removes all class filtering support from AnnotationScanner since that functionality was effectively unused.
|
See also #25477 |
|
@sbrannen I am learning the spring-core source codes rencently. |
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Jul 28, 2020
PR spring-projectsgh-25429 brought it to our attention that there was a bug in AnnotationScanner when using a non-null class filter that filtered out classes; however, it turns out that there is no production code that utilizes the package-private class filtering support. This commit therefore removes all class filtering support from AnnotationScanner since that functionality is effectively unused. Closes spring-projectsgh-25477
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
Prior to this commit, scanning for annotations resulted in an infinite loop when using the INHERITED_ANNOTATIONS search strategy and a class filter that filters out visited classes. This commit avoids an infinite loop in AnnotationsScanner's processClassInheritedAnnotations(...) method by skipping the current level of the class hierarchy when the current source class has been filtered out. Closes spring-projectsgh-25429
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
PR spring-projectsgh-25429 brought it to our attention that there was a bug in AnnotationScanner when using a non-null class filter that filtered out classes; however, it turns out that there is no production code that utilizes the package-private class filtering support. This commit therefore removes all class filtering support from AnnotationScanner since that functionality is effectively unused. Closes spring-projectsgh-25477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code
isFiltered(source, context, classFilter)when true,would cause dead circle.
Maybe new code is right.