Fix race condition in WriteResultPublisher between subscription and completion in publishComplete #24989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
changed the title
rstoyanchev
added
the
for: backport-to-5.1.x
spring-projects-issues
added
status: backported
|
Thanks for spotting this! |
zx20110729
pushed a commit
to zx20110729/spring-framework
that referenced
this pull request
Feb 18, 2022
Backport of c35b3e5 Closes spring-projectsgh-24989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug I was experiencing was that sometimes with a WebFlux on Tomcat setup, responses were not being emitted (despite the Publisher being returned from my Controller methods completing successfully). Similar to #23096