Support variable resolution of wildcard types #24145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `ResolvableType` so that variable referenced can be resolved against wildcard types. Prior to this commit, given a type: Map<String, ? extends List<? extends CharSequence>> Calling `type.getGeneric(1).asCollection().resolveGeneric()` would return `null`. This was because the `List` variable `E` referenced a wildcard type which `resolveVariable` did not support. Closes spring-projectsgh-24145
philwebb
force-pushed
the
resolvewildcards
branch
from
5b6665b
to
746ac8a
Compare
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
jhoeller
added
the
for: backport-to-5.1.x
spring-projects-issues
added
status: backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ResolvableTypeso that variable referenced can be resolvedagainst wildcard types. Prior to this commit, given a type:
Calling
type.getGeneric(1).asCollection().resolveGeneric()wouldreturn
null. This was because theListvariableEreferenced awildcard type which
resolveVariabledid not support.