Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve part content type determination in MockMultipartHttpServletRequest #24074

Conversation

Syquel
Copy link

@Syquel Syquel commented Nov 25, 2019

The MockMultipartHttpServletRequest does not support handling of non-file multiparts.
This aligns the behavior of MockMultipartHttpServletRequest with StandardMultipartHttpServletRequest and DefaultMultipartHttpServletRequest, which support such scenarios by looking up content types in file as well as non-file parts of the request.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 25, 2019
@rstoyanchev rstoyanchev self-assigned this Nov 29, 2019
@rstoyanchev rstoyanchev added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 29, 2019
@rstoyanchev rstoyanchev added this to the 5.2.2 milestone Nov 29, 2019
@rstoyanchev rstoyanchev changed the title Fix determination of content type in multipart request mock. Improve part content type determination in MockMultipartHttpServletRequest Nov 29, 2019
rstoyanchev pushed a commit that referenced this pull request Nov 29, 2019
rstoyanchev added a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants