Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce failOnError flag in TestContextAotGenerator #30898

Closed
1 task done
sbrannen opened this issue Jul 15, 2023 · 0 comments
Closed
1 task done

Introduce failOnError flag in TestContextAotGenerator #30898

sbrannen opened this issue Jul 15, 2023 · 0 comments
Assignees
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: task A general task
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 15, 2023

Overview

When an error is encountered during AOT processing in TestContextAotGenerator, a DEBUG or WARN message is logged, and processing will continue.

This behavior is acceptable at build-time; however, such errors will be silently ignored within our own integration tests since we do not have a mechanism for checking the log output.

We should therefore introduce a mechanism to "fail on error" during test AOT processing.

NOTE: This feature is currently targeted for internal use only.

Related Issues

Deliverables

  • Introduce a failOnError flag in TestContextAotGenerator.
    • When set to true, any error encountered during AOT processing should result in an exception that fails the overall process. When set to false (the default), the previous behavior remains unchanged: a DEBUG or WARN message will be logged, and processing will continue.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jul 15, 2023
@sbrannen sbrannen added this to the 6.0.12 milestone Jul 15, 2023
@sbrannen sbrannen self-assigned this Jul 15, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 15, 2023
This commit introduces a `failOnError` flag in TestContextAotGenerator.
When set to `true`, any error encountered during AOT processing will
result in an exception that fails the overall process. When set to
`false` (the default), the previous behavior remains unchanged: a DEBUG
or WARN message will be logged, and processing will continue.

This feature is currently only used for internal testing.

See spring-projectsgh-30861
Closes spring-projectsgh-30898
@sbrannen sbrannen removed the type: enhancement A general enhancement label Jul 15, 2023
@sbrannen sbrannen added the type: task A general task label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant