Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private init/destroy methods are not supported in AOT mode #30692

Closed
sbrannen opened this issue Jun 19, 2023 · 1 comment
Closed

private init/destroy methods are not supported in AOT mode #30692

sbrannen opened this issue Jun 19, 2023 · 1 comment
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another theme: aot An issue related to Ahead-of-time processing type: bug A general bug

Comments

@sbrannen
Copy link
Member

sbrannen commented Jun 19, 2023 •
edited

See #30654 for background details.

Related Issues
@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing labels Jun 19, 2023
@sbrannen sbrannen added this to the 6.0.11 milestone Jun 19, 2023
@sbrannen sbrannen self-assigned this Jun 19, 2023
@sbrannen sbrannen mentioned this issue Jun 19, 2023
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 20, 2023
@sbrannen
Support private init/destroy methods in AOT mode
936c180 
Closes spring-projectsgh-30692
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 21, 2023
@sbrannen
Support private init/destroy methods in AOT mode
20ba6fd 
Closes spring-projectsgh-30692
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 21, 2023
@sbrannen
Support private init/destroy methods in AOT mode
e8bbcd0 
Closes spring-projectsgh-30692
sbrannen added a commit that referenced this issue Jun 21, 2023
@sbrannen
Test status quo for private init/destroy methods in AOT mode
4879b56 
This commit only tests which init/destroy methods are "registered" in
AOT mode.

This commit does NOT test that the registered methods can actually be
invoked in AOT mode: that will be addressed in a separate commit.

See gh-30692
@sbrannen sbrannen mentioned this issue Jun 21, 2023
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 21, 2023
@sbrannen
Support private init/destroy methods in AOT mode
3399e4d 
Closes spring-projectsgh-30692
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 21, 2023
@sbrannen
Support private init/destroy methods in AOT mode
e06698d 
Closes spring-projectsgh-30692
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 22, 2023
@sbrannen
Support [package-]private init/destroy methods in AOT mode
ee6f7b1 
Prior to this commit, private (and non-visible package-private)
init/destroy methods were not supported in AOT mode. The reason is that
such methods are tracked using their fully-qualified method names, and
the AOT support for init/destroy method previously did not take
fully-qualified method names into account. In addition, the invocation
order of init/destroy methods differed between standard JVM mode and
AOT mode.

This commit addresses these issues in the following ways.

- AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(),
  DisposableBeanAdapter.determineDestroyMethod(), and
  BeanDefinitionPropertiesCodeGenerator.addInitDestroyHint() now parse
  fully-qualified method names to locate the correct init/destroy
  methods.

- AbstractAutowireCapableBeanFactory and DisposableBeanAdapter delegate
  to a new InitDestroyMethodUtils class which encapsulates the parsing
  of fully-qualified method names; however,
  BeanDefinitionPropertiesCodeGenerator duplicates this logic since it
  resides in a different package, and we do not currently want to make
  the functionality in InitDestroyMethodUtils public.

- Init/destroy methods detected via annotations (such as @PostConstruct
  and @PreDestroy) are now invoked prior to init/destroy methods that
  are explicitly configured by name or convention. This aligns with the
  invocation order in standard JVM mode; however,
  InitializingBean#afterPropertiesSet() and DisposableBean#destroy()
  are still invoked before annotated init/destroy methods in AOT mode
  which differs from standard JVM mode.

- Unit and integration tests have been updated to test the revised
  behavior.

Closes spring-projectsgh-30692
@sbrannen sbrannen mentioned this issue Jun 22, 2023
Closed
@sbrannen
Copy link
Member Author

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2023
@sbrannen sbrannen removed this from the 6.0.11 milestone Jun 22, 2023
@sbrannen sbrannen added the status: superseded An issue that has been superseded by another label Jun 22, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 23, 2023
@sbrannen
Support [package-]private init/destroy methods in AOT mode
066dfe3 
Prior to this commit, private (and non-visible package-private)
init/destroy methods were not supported in AOT mode. The reason is that
such methods are tracked using their fully-qualified method names, and
the AOT support for init/destroy method previously did not take
fully-qualified method names into account. In addition, the invocation
order of init/destroy methods differed between standard JVM mode and
AOT mode.

This commit addresses these issues in the following ways.

- AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(),
  DisposableBeanAdapter.determineDestroyMethod(), and
  BeanDefinitionPropertiesCodeGenerator.addInitDestroyHint() now parse
  fully-qualified method names to locate the correct init/destroy
  methods.

- AbstractAutowireCapableBeanFactory and DisposableBeanAdapter delegate
  to a new MethodDescriptor record which encapsulates the parsing of
  fully-qualified method names; however,
  BeanDefinitionPropertiesCodeGenerator duplicates this logic since it
  resides in a different package, and we do not currently want to make
  MethodDescriptor public.

- Init/destroy methods detected via annotations (such as @PostConstruct
  and @PreDestroy) are now invoked prior to init/destroy methods that
  are explicitly configured by name or convention. This aligns with the
  invocation order in standard JVM mode; however,
  InitializingBean#afterPropertiesSet() and DisposableBean#destroy()
  are still invoked before annotated init/destroy methods in AOT mode
  which differs from standard JVM mode.

- Unit and integration tests have been updated to test the revised
  behavior.

Closes spring-projectsgh-30692

f
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 24, 2023
@sbrannen
Support [package-]private init/destroy methods in AOT mode
3181dca 
Prior to this commit, private (and non-visible package-private)
init/destroy methods were not supported in AOT mode. The reason is that
such methods are tracked using their fully-qualified method names, and
the AOT support for init/destroy methods previously did not take
fully-qualified method names into account. In addition, the invocation
order of init/destroy methods differed vastly between standard JVM mode
and AOT mode.

This commit addresses these issues in the following ways.

- AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(),
  DisposableBeanAdapter.determineDestroyMethod(), and
  BeanDefinitionPropertiesCodeGenerator.addInitDestroyHint() now parse
  fully-qualified method names to locate the correct init/destroy
  methods.

- AbstractAutowireCapableBeanFactory and DisposableBeanAdapter delegate
  to a new MethodDescriptor record which encapsulates the parsing of
  fully-qualified method names; however,
  BeanDefinitionPropertiesCodeGenerator duplicates this logic since it
  resides in a different package, and we do not currently want to make
  MethodDescriptor public.

- Init/destroy methods detected via annotations (such as @PostConstruct
  and @PreDestroy) are now invoked prior to init/destroy methods that
  are explicitly configured by name or convention. This aligns with the
  invocation order in standard JVM mode; however,
  InitializingBean#afterPropertiesSet() and DisposableBean#destroy()
  are still invoked before annotated init/destroy methods in AOT mode
  which differs from standard JVM mode.

- Unit and integration tests have been updated to test the revised
  behavior.

Closes spring-projectsgh-30692
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sbrannen @mdeinum
Test status quo for private init/destroy methods in AOT mode
5656fa8 
This commit only tests which init/destroy methods are "registered" in
AOT mode.

This commit does NOT test that the registered methods can actually be
invoked in AOT mode: that will be addressed in a separate commit.

See spring-projectsgh-30692
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sbrannen @mdeinum
Support [package-]private init/destroy methods in AOT mode
bc188a4 
Prior to this commit, private (and non-visible package-private)
init/destroy methods were not supported in AOT mode. The reason is that
such methods are tracked using their fully-qualified method names, and
the AOT support for init/destroy methods previously did not take
fully-qualified method names into account. In addition, the invocation
order of init/destroy methods differed vastly between standard JVM mode
and AOT mode.

This commit addresses these issues in the following ways.

- AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(),
  DisposableBeanAdapter.determineDestroyMethod(), and
  BeanDefinitionPropertiesCodeGenerator.addInitDestroyHint() now parse
  fully-qualified method names to locate the correct init/destroy
  methods.

- AbstractAutowireCapableBeanFactory and DisposableBeanAdapter delegate
  to a new MethodDescriptor record which encapsulates the parsing of
  fully-qualified method names; however,
  BeanDefinitionPropertiesCodeGenerator duplicates this logic since it
  resides in a different package, and we do not currently want to make
  MethodDescriptor public.

- Init/destroy methods detected via annotations (such as @PostConstruct
  and @PreDestroy) are now invoked prior to init/destroy methods that
  are explicitly configured by name or convention. This aligns with the
  invocation order in standard JVM mode; however,
  InitializingBean#afterPropertiesSet() and DisposableBean#destroy()
  are still invoked before annotated init/destroy methods in AOT mode
  which differs from standard JVM mode.

- Unit and integration tests have been updated to test the revised
  behavior.

Closes spring-projectsgh-30692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbrannen