Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HttpServiceProxyFactory#createClient Kotlin extension #29942

Closed
sdeleuze opened this issue Feb 7, 2023 · 4 comments
Closed

Introduce HttpServiceProxyFactory#createClient Kotlin extension #29942

sdeleuze opened this issue Feb 7, 2023 · 4 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Milestone

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Feb 7, 2023

To allow createClient<TestHttpService>() syntax instead of createClient(TestHttpService::class.java).

@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement theme: kotlin An issue related to Kotlin support labels Feb 7, 2023
@sdeleuze sdeleuze added this to the 6.0.5 milestone Feb 7, 2023
@sdeleuze sdeleuze self-assigned this Feb 7, 2023
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Feb 7, 2023
@srydberg
Copy link

@sdeleuze I get the below error, and this change seems to break java modules since you are exporting a package already included in spring-web from the spring-webflux module. Is this tracked or do we have a workaround?

...module-info.java:1: error: module com.module-a reads package org.springframework.web.service.invoker from both spring.webflux and spring.web module com.module-a { ^

@sbrannen
Copy link
Member

sbrannen commented Feb 27, 2023

@srydberg, that appears to have been oversight: HttpServiceProxyFactoryExtensions should be in the same module as HttpServiceProxyFactory.

Would you mind creating a new ticket to track this?

@sdeleuze
Copy link
Contributor Author

I have created #30042 related issue since I was about to push the fix, so no need to create it. Thanks for catching this.

@srydberg
Copy link

Thanks alot 🙇🏻‍♂️

mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants