AnnotatedElementUtils.findMergedRepeatableAnnotations does not fetch results when other attributes exist for container annotation #29686
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: backport
An issue that is a backport of another issue to a maintenance branch
type: regression
A bug that is also a regression
Milestone
Comments
github-actions
bot
added
in: core
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Dec 13, 2022
Prior to this commit, there was a bug in the implementation of StandardRepeatableContainers.computeRepeatedAnnotationsMethod() which has existed since Spring Framework 5.2 (when StandardRepeatableContainers was introduced). Specifically, StandardRepeatableContainers ignored any repeatable container annotation if it declared attributes other than `value()`. However, Java permits any number of attributes in a repeatable container annotation. In addition, the changes made in conjunction with spring-projectsgh-20279 made the bug in StandardRepeatableContainers apparent when using the getMergedRepeatableAnnotations() or findMergedRepeatableAnnotations() method in AnnotatedElementUtils, resulting in regressions for the behavior of those two methods. This commit fixes the regressions and bug by altering the logic in StandardRepeatableContainers.computeRepeatedAnnotationsMethod() so that it explicitly looks for the `value()` method and ignores any other methods declared in a repeatable container annotation candidate. See spring-projectsgh-29685 Closes spring-projectsgh-29686
|
Fixed in 5ddc984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport of gh-29685
The text was updated successfully, but these errors were encountered: