Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-annotations are unnecessarily synthesized in MergedAnotations #28704

Closed
sbrannen opened this issue Jun 25, 2022 · 0 comments
Closed

Meta-annotations are unnecessarily synthesized in MergedAnotations #28704

sbrannen opened this issue Jun 25, 2022 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Milestone

Comments

@sbrannen
Copy link
Member

While analyzing the claim in #28702, I discovered that meta-annotations are unnecessarily synthesized when attempting to synthesize a MergedAnnotation retrieved via the MergedAnnotations.from(AnnotatedElement, ...).get(<annotationType>) API.

This is a regression in our merged annotation support introduced when the MergedAnnotations API replaced our previous support, and the source of the bug is the logic in TypeMappedAnnotation#createSynthesized().

In theory, I could have detected this regression earlier when I had to change a test in BootstrapUtilsTests (see commit ce87285), since @BootstrapWith should never have been synthesized; however, I overlooked that detail at the time.

@sbrannen sbrannen added type: regression A bug that is also a regression in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 25, 2022
@sbrannen sbrannen added this to the 5.3.22 milestone Jun 25, 2022
@sbrannen sbrannen self-assigned this Jun 25, 2022
@sbrannen sbrannen added the theme: aot An issue related to Ahead-of-time processing label Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Projects
None yet
Development

No branches or pull requests

1 participant