CGLIB BeanCopier falls back to ClassLoader.defineClass for public target
#28699
Comments
spring-projects-issues
added
the
status: waiting-for-triage
public class AppTest {
@Test
public void test() {
BeanCopier copier = BeanCopier.create(A.class, B.class, false);
System.out.println("copier:" + copier);
}
}
class A {
}
class B {
} |
because your class not public class, you can try create public class A and B |
|
so, i wanna know that you add some param? |
|
can you show me the A class code ? |
|
i had change oracle jdk17,still error. |
|
|
i try many way to solve this problem, but any way had fail |
me too |
|
Same issue.
public class Person {
String name;
Integer age;
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public Integer getAge() {
return age;
}
public void setAge(Integer age) {
this.age = age;
}
}import java.util.List;
public class PersonVO extends Person {
List<String> hobbies;
public List<String> getHobbies() {
return hobbies;
}
public void setHobbies(List<String> hobbies) {
this.hobbies = hobbies;
}
}
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cglib.beans.BeanCopier;
@SpringBootApplication
public class BeanCopierDemoApplication {
private static final Log logger = LogFactory.getLog(BeanCopierDemoApplication.class);
public static void main(String[] args) {
PersonVO personVO = testBeanCopy();
logger.info(personVO);
SpringApplication.run(BeanCopierDemoApplication.class, args);
}
public static PersonVO testBeanCopy() {
Person person = new Person();
person.setName("nico");
person.setAge(18);
PersonVO personVO = new PersonVO();
final BeanCopier beanCopier = BeanCopier.create(Person.class, PersonVO.class, false);
beanCopier.copy(person, personVO, null);
personVO.setHobbies(null);
return personVO;
}
}
In my case, to resolve it, just add vm options "--add-opens java.base/java.lang=ALL-UNNAMED" So i think maybe it's a compatibility issue with CGLIB? |
|
@mazhewei, thank you, your post was very helpful for me! |
|
I had a similar problem and after taking the answer from @mazhewei and @invzbl3 got it working. The main problem here could be a Intellij-Settings-Problem. For me following Setting for the argLine for the Tests with Maven was disabled.
So when i runned the Test in the console with mvn clean install Test was ok but into IntelliJ was failed. Then i wrote in the pom.xml some configuration for the surefire plugin: In my case, i have more package/module opened because of another tests but the point is after doing this i had not to write the add-opens package/module for the single test. Maybe @SuperEdison could try this solution and if all is fine issue could be close. |
|
我也遇到这种问题. 加了--add-opens也不好使. |
rstoyanchev
added
the
in: core
|
|
yes, i agree |
|
Same problem here. add a mark to be notified. |
|
BTW, I am using the latest version spring 6.0.12 |
This comment was marked as outdated.
This comment was marked as outdated.
snicoll
added
for: external-project
This comment was marked as off-topic.
This comment was marked as off-topic.
|
It seems this is actually an issue with our context class patch which only works for non-public classes but not for public classes. I got a fix ready to be rolled into 6.0.14, to be backported to 5.3.31 as well. That said, please note that Spring's repackaged CGLIB fork is not meant to be used directly. Its primary role is supporting Spring's AOP framework and related core container functionality. We do not use CGLIB's |
jhoeller
added
type: bug
jhoeller
changed the title
ClassLoader.defineClass for public target on JDK 17
jhoeller
changed the title
ClassLoader.defineClass for public target on JDK 17ClassLoader.defineClass for public target
jhoeller
added
the
for: backport-to-5.3.x
github-actions
bot
removed
the
for: backport-to-5.3.x
|
@jhoeller This is very good, looking forward to the official release of this version! |
github-actions
bot
added
the
status: backported
|
This is available in the latest 6.0.14 snapshot now and will be available in the upcoming 5.3.31 snapshot in a few minutes (which can be obtained from repo.spring.io). Please give either of those a try ahead of our release date in November so that we have confidence that the fix works for good now. Alternatively, you could also patch a local Spring Framework setup with the latest |
sbrannen
changed the title
ClassLoader.defineClass for public targetBeanCopier falls back to ClassLoader.defineClass for public target
yep, spring could consider if that's deleted the cglib's 'BeanCopier' or using another way to support it |
|
For the time being, we are trying to make That said, I would appreciate early testing against 6.0.14 / 5.3.31 snapshot builds (from https://repo.spring.io) to verify that |
springframework.version 5.3.21
jdk.version 17
old issue #28530
I find this error still happening that is fault way to use?
@jhoeller
The text was updated successfully, but these errors were encountered: