Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RouterFunction ordering in Spring MVC #28595

Closed
rstoyanchev opened this issue Jun 9, 2022 · 2 comments
Closed

Support RouterFunction ordering in Spring MVC #28595

rstoyanchev opened this issue Jun 9, 2022 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.3.21

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jun 9, 2022 •
edited

RouterFunctionMapping in Spring MVC does not support ordering. By comparison, the WebFlux RouterFunctionMapping does, refactored in #21861 to use ObjectProvider, but always had the support for it.

This was uncovered in spring-projects/spring-graphql#404.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Jun 9, 2022
@rstoyanchev rstoyanchev added this to the 5.3.21 milestone Jun 9, 2022
@rstoyanchev rstoyanchev self-assigned this Jun 9, 2022
@rstoyanchev rstoyanchev mentioned this issue Jun 9, 2022
Closed
@tudormarc
Copy link

@rstoyanchev can I make a PR for this? :)

@rstoyanchev
Copy link
Contributor Author

@tudormarc no objections, but it might not be as simple as making the two identical due to the detectHandlerFunctionsInAncestorContexts flag on the WebMvc side.

rstoyanchev added a commit that referenced this issue Jun 14, 2022
@rstoyanchev
Polishing
d28d603 
See gh-28595
rstoyanchev added a commit that referenced this issue Jun 14, 2022
@rstoyanchev
Revise commit #52d068 with corrected test
8c77711 
Update test detecting RouterFunction beans in parent contexts to use
different bean names and avoid shadowing. Changed the fix accordingly
given that BeanProvider does detect beans in parent contexts.

See gh-28595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.3.21
Development

No branches or pull requests
2 participants
@rstoyanchev @tudormarc