New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warn log message for empty static resource locations #27575
Comments
Addressed with 76c9306. |
I wonder if the info logging is perhaps still a little too heavy. Here's some output from a WebFlux app with no static resources and no webjars using Framework 5.3.10:
And here's the output from the same app after upgrading to Framework 5.3.12 snapshots:
It's a similar story with MVC. Here's the output with Framework 5.3.10:
And with Framework 5.3.12-SNAPSHOT:
Unfortunately, the new log output doesn't feel useful enough to me to warrant being at info level. I would be quite happy if nothing was logged (as happens at the moment with 5.3.10) so dropping the new logging down to debug is my preference. If something is logged at info level, I think it would make the logging more useful if it included the paths at which those locations will be served. It looks as if that may require the logging to be moved as I don't think the handlers know about the paths. |
I'm fine to drop the logging to debug. It would match what we do for other handler mappings. In terms of URL paths, |
At DEBUG level we actually have logging from the static resources SimpleUrlHandlerMapping which includes both the paths and individual resource handlers, each with its (already filtered) locations:
So I've removed those log messages entirely since they don't add anything new and don't have all the relevant information anyway. |
The change to filter non-existing locations, related to #27538, caused those messages to appear automatically in scenarios where there are no static resource locations. The warning messages should be updated to take into account that static resource locations may have been configured but none actually exist.
The text was updated successfully, but these errors were encountered: