Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeUriComponentsContributor#hasContributors: method name is not compliant with its intention #27271

Closed
lijinliangyihao opened this issue Aug 13, 2021 · 0 comments
Closed

CompositeUriComponentsContributor#hasContributors: method name is not compliant with its intention #27271

lijinliangyihao opened this issue Aug 13, 2021 · 0 comments
Assignees
@sbrannen
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.3.10

Comments

@lijinliangyihao
Copy link

lijinliangyihao commented Aug 13, 2021 •
edited by sbrannen

Affects: 5.3.8

This method named hasContributors() has a body that returns true when there are no contributors.

public boolean hasContributors() {
   return this.contributors.isEmpty();
}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 13, 2021
@sbrannen sbrannen self-assigned this Aug 13, 2021
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 13, 2021
@sbrannen sbrannen added this to the 5.3.10 milestone Aug 13, 2021
@sbrannen sbrannen added the for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x label Aug 13, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x labels Aug 13, 2021
Closed
sbrannen added a commit that referenced this issue Aug 18, 2021
@sbrannen
Fix and document CompositeUriComponentsContributor#hasContributors()
ab2a861 
Prior to this commit, the hasContributors() method incorrectly returned
false if contributors had been configured.

This commit fixes the logic in hasContributors() and documents it.

Closes #27271
@sync-by-unito sync-by-unito bot mentioned this issue Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Fix and document CompositeUriComponentsContributor#hasContributors()
6b8e565 
Prior to this commit, the hasContributors() method incorrectly returned
false if contributors had been configured.

This commit fixes the logic in hasContributors() and documents it.

Closes spring-projects#27271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.3.10
Development

No branches or pull requests
3 participants
@sbrannen @spring-projects-issues @lijinliangyihao