Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockHttpServletResponse.characterEncoding should not be @Nullable #27219

Closed
sbrannen opened this issue Jul 28, 2021 · 0 comments
Closed

MockHttpServletResponse.characterEncoding should not be @Nullable #27219

sbrannen opened this issue Jul 28, 2021 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module type: bug A general bug
Milestone
5.3.10

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 28, 2021 •
edited

According to the Servlet spec, getCharacterEncoding() should never return null. Consequently, MockHttpServletResponse.characterEncoding should not be @Nullable.

Similarly, MockHttpServletResponse.reset() should set the characterEncoding to WebUtils.DEFAULT_CHARACTER_ENCODING instead of null.

Ensuring that characterEncoding is never null will also help to simplify the implementation of several methods in MockHttpServletResponse that currently have non-null checks for the characterEncoding.
@sbrannen sbrannen added in: test Issues in the test module type: bug A general bug labels Jul 28, 2021
@sbrannen sbrannen added this to the 5.3.10 milestone Jul 28, 2021
@sbrannen sbrannen self-assigned this Jul 28, 2021
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 28, 2021
@sbrannen
Ensure characterEncoding in MockHttpServletResponse is non-null
6fcb84c 
Closes spring-projectsgh-27219
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jul 28, 2021
@sbrannen
Sync changes to MockHttpServletResponse
97687d5 
See spring-projectsgh-27219
@sbrannen sbrannen changed the title MockHttpServletResponse.characterEncoding should not be @Nullable MockHttpServletResponse.characterEncoding should not be @Nullable Jul 29, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Ensure characterEncoding in MockHttpServletResponse is non-null
b3d5840 
Closes spring-projectsgh-27219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: bug A general bug
Projects
None yet
Milestone
5.3.10
Development

No branches or pull requests
1 participant
@sbrannen