Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference docs missing left-hand side navigation #27177

Closed
rstoyanchev opened this issue Jul 15, 2021 · 3 comments
Closed

Reference docs missing left-hand side navigation #27177

rstoyanchev opened this issue Jul 15, 2021 · 3 comments
Assignees
@sbrannen
Labels
type: documentation A documentation task
Milestone
5.3.10

Comments

@rstoyanchev
Copy link
Contributor

It displays fine in 5.3.8 but in 5.3.9 it's missing.
@rstoyanchev rstoyanchev added the type: documentation A documentation task label Jul 15, 2021
@rstoyanchev rstoyanchev added this to the 5.3.10 milestone Jul 15, 2021
@shivansh29
Copy link

Hey I see your issue
and confused what kind of fix are you expecting is it a documentation fix
or code fix
feels like code fix

@sbrannen
Copy link
Member

@shivansh29, the type: documentation label means that the work required is related to documentation published by the framework. Whether it is technically code (in the build scripts) or prose/markup that is to be changed does not matter.

The cause for the regression is likely commit 71995a9.

@sbrannen sbrannen self-assigned this Jul 17, 2021
@diguage diguage mentioned this issue Jul 18, 2021
Closed
This was referenced Jul 20, 2021
Closed
Closed
Closed
@bclozel bclozel mentioned this issue Jul 30, 2021
Closed
This was referenced Aug 13, 2021
Closed
Closed
@fupgang
Copy link

fupgang commented Sep 3, 2021

The table of content is still missing for the current version (5.3.9). Won't this be fixed until the release of 5.3.10?
I wonder if there is a workflow to regenerate and publish a fixed reference documentation?

@sync-by-unito sync-by-unito bot mentioned this issue Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Reintroduce left-hand side navigation in ref docs
c238d96 
A side effect of 71995a9 caused the
dynamic table of contents in the left-hand side navigation to no longer
be displayed, likely due to the missing "details" DIV.

This commit addresses this issue by applying the custom header only to
index.adoc.

Consequently, the TOC is now displayed again on all pages except the
index page, but the customized header is no longer applied to those
pages.

We may revisit this issue if we decide that we want the custom header
on all pages (and not just the index page).

Closes spring-projectsgh-27177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
type: documentation A documentation task
Projects
None yet
Milestone
5.3.10
Development

No branches or pull requests
4 participants
@sbrannen @rstoyanchev @shivansh29 @fupgang