Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JettyHttpHandlerAdapter is not aware of Server[Request|Response]Wrapper #27146

Closed
migedt opened this issue Jul 8, 2021 · 0 comments
Closed

JettyHttpHandlerAdapter is not aware of Server[Request|Response]Wrapper #27146

migedt opened this issue Jul 8, 2021 · 0 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.3.9

Comments

@migedt
Copy link

migedt commented Jul 8, 2021

Affects: 5.3.7

In JettyServerHttpRequest#createHeaders, it is assumed that the given HttpServletRequest is a org.eclipse.jetty.server.Request, while it could be a HttpServletRequestWrapper. Similarly, JettyServerHttpResponse#createHeaders assumes that the given response is a org.eclipse.jetty.server.Response, while it could be a HttpServletResponseWrapper.

Similar to #22143, but just for Jetty.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 8, 2021
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 8, 2021
@jhoeller jhoeller added this to the 5.3.9 milestone Jul 8, 2021
@poutsma poutsma self-assigned this Jul 8, 2021
@poutsma poutsma closed this as completed in 9cbb5af Jul 8, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Jul 14, 2021
Merged
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
@poutsma @Zoran0104
Support request/response wrappers in JettyHttpHandlerAdapter
d933aef 
This commit makes JettyServerHttpRequest aware of
HttpServletRequestWrapper, and JettyServerHttpResponse aware of
HttpServletResponseWrapper.

Closes spring-projectsgh-27146
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Support request/response wrappers in JettyHttpHandlerAdapter
04740b0 
This commit makes JettyServerHttpRequest aware of
HttpServletRequestWrapper, and JettyServerHttpResponse aware of
HttpServletResponseWrapper.

Closes spring-projectsgh-27146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.3.9
Development

No branches or pull requests
4 participants
@poutsma @jhoeller @spring-projects-issues @migedt