Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty10RequestUpgradeStrategy use an old jetty 9 class HandshakeRFC6455 #27121

Closed
leonchen83 opened this issue Jul 2, 2021 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@leonchen83
Copy link
Contributor

Affects: <Spring Framework version>
5.3.8

spring framework version
5.3.8

jetty version
10.0.5

jetty dependency

        <dependency>
            <groupId>org.eclipse.jetty</groupId>
            <artifactId>jetty-server</artifactId>
        </dependency>
        <dependency>
            <groupId>org.eclipse.jetty</groupId>
            <artifactId>jetty-webapp</artifactId>
        </dependency>
        <dependency>
            <groupId>org.eclipse.jetty</groupId>
            <artifactId>jetty-servlet</artifactId>
        </dependency>
        <dependency>
            <groupId>org.eclipse.jetty.websocket</groupId>
            <artifactId>websocket-jetty-server</artifactId>
        </dependency>

class Jetty10RequestUpgradeStrategy use an old jetty 9 class HandshakeRFC6455 following

private static final String[] SUPPORTED_VERSIONS = new String[] { String.valueOf(HandshakeRFC6455.VERSION) };

the code should be

private static final String[] SUPPORTED_VERSIONS = new String[] { "13" };
@leonchen83 leonchen83 changed the title [BUG] [BUG] Jetty10RequestUpgradeStrategy use an old jetty 9 class HandshakeRFC6455 Jul 2, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 2, 2021
@snicoll snicoll changed the title [BUG] Jetty10RequestUpgradeStrategy use an old jetty 9 class HandshakeRFC6455 Jetty10RequestUpgradeStrategy use an old jetty 9 class HandshakeRFC6455 Jul 2, 2021
@rstoyanchev rstoyanchev self-assigned this Jul 9, 2021
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 9, 2021
@rstoyanchev rstoyanchev added this to the 5.3.9 milestone Jul 9, 2021
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants