Implement equals, hashCode, & toString in BeanMethod and *Metadata types #27076
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: enhancement
A general enhancement
Milestone
Comments
snicoll
added
the
status: waiting-for-triage
snicoll
changed the title
sbrannen
added
in: core
sbrannen
changed the title
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Jun 23, 2021
|
Current work on this issue can be viewed in https://github.com/sbrannen/spring-framework/commits/issues/gh-27076-BeanMethod-equals-hashCode-toString |
Zoran0104
pushed a commit
to Zoran0104/spring-framework
that referenced
this issue
Aug 20, 2021
Prior to this commit, ConfigurationClass implemented equals(), hashCode(), and toString(), but BeanMethod did not. This commit introduces equals(), hashCode(), and toString() implementations in BeanMethod for consistency with ConfigurationClass to make it possible to use BeanMethod instances to index additional metadata as well. In order to properly implement equals() in BeanMethod, the method argument types are required, but these are not directly available in BeanMethod. However, they are available via ASM when processing @bean methods. This commit therefore implements equals(), hashCode(), and toString() in SimpleMethodMetadata which BeanMethod delegates to. For completeness, this commit also implements equals(), hashCode(), and toString() in StandardClassMetadata, StandardMethodMetadata, and SimpleAnnotationMetadata. Closes spring-projectsgh-27076
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Prior to this commit, ConfigurationClass implemented equals(), hashCode(), and toString(), but BeanMethod did not. This commit introduces equals(), hashCode(), and toString() implementations in BeanMethod for consistency with ConfigurationClass to make it possible to use BeanMethod instances to index additional metadata as well. In order to properly implement equals() in BeanMethod, the method argument types are required, but these are not directly available in BeanMethod. However, they are available via ASM when processing @bean methods. This commit therefore implements equals(), hashCode(), and toString() in SimpleMethodMetadata which BeanMethod delegates to. For completeness, this commit also implements equals(), hashCode(), and toString() in StandardClassMetadata, StandardMethodMetadata, and SimpleAnnotationMetadata. Closes spring-projectsgh-27076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For consistency with
ConfigurationClassas it would be useful to be able to use these to index additional metadata.The text was updated successfully, but these errors were encountered: