DefaultPathSegment allows shared empty parameters map to be mutated #27064
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
sbrannen
added
in: web
sbrannen
changed the title
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Jun 15, 2021
Prior to this commit, if a PathContainer was created using Options.MESSAGE_ROUTE, DefaultPathSegment#parameters() returned a mutable map which would allow the user to modify the contents of the static, shared EMPTY_PARAMS map in DefaultPathContainer. This commit prevents corruption of the shared EMPTY_PARAMS map by ensuring that parameters stored in DefaultPathSegment are always immutable. Closes spring-projectsgh-27064
spring-projects-issues
added
the
status: backported
Zoran0104
pushed a commit
to Zoran0104/spring-framework
that referenced
this issue
Aug 20, 2021
Prior to this commit, if a PathContainer was created using Options.MESSAGE_ROUTE, DefaultPathSegment#parameters() returned a mutable map which would allow the user to modify the contents of the static, shared EMPTY_PARAMS map in DefaultPathContainer. This commit prevents corruption of the shared EMPTY_PARAMS map by ensuring that parameters stored in DefaultPathSegment are always immutable. Closes spring-projectsgh-27064
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Prior to this commit, if a PathContainer was created using Options.MESSAGE_ROUTE, DefaultPathSegment#parameters() returned a mutable map which would allow the user to modify the contents of the static, shared EMPTY_PARAMS map in DefaultPathContainer. This commit prevents corruption of the shared EMPTY_PARAMS map by ensuring that parameters stored in DefaultPathSegment are always immutable. Closes spring-projectsgh-27064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #27063 made me aware of the following existing bug.
If a
PathContaineris created usingOptions.MESSAGE_ROUTE,DefaultPathSegment#parameters()returns a mutable map which allows the user to modify the contents of the static, sharedEMPTY_PARAMSmap inDefaultPathContainer.The text was updated successfully, but these errors were encountered: