Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that baseName in ResourceBundleMessageSource does not support multiple locations #27038

Closed
snicoll opened this issue Jun 8, 2021 · 0 comments
Closed

Clarify that baseName in ResourceBundleMessageSource does not support multiple locations #27038

snicoll opened this issue Jun 8, 2021 · 0 comments
Assignees
@poutsma
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Milestone
5.3.9

Comments

@snicoll
Copy link
Member

snicoll commented Jun 8, 2021

See spring-projects/spring-boot#26712 for background.

There are various places where multiple locations can be searched for and this one is delegating ultimately to ResourceBundle#getBundle. It would be nice if the reference guide was extra explicit about the fact that multiple bundles at the same location in the classpath in different modules won't be merged.
@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 8, 2021
@snicoll snicoll mentioned this issue Jun 8, 2021
Closed
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 8, 2021
@sbrannen sbrannen changed the title Clarify that baseName on ResourceBasedMessageSource does not support multiple locations Clarify that baseName in ResourceBundleMessageSource does not support multiple locations Jun 8, 2021
@sbrannen sbrannen self-assigned this Jun 8, 2021
@sbrannen sbrannen added this to the 5.3.9 milestone Jun 8, 2021
@sbrannen sbrannen removed their assignment Jul 5, 2021
@poutsma poutsma self-assigned this Jul 13, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Jul 14, 2021
Merged
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
@poutsma @Zoran0104
Document ResourceBundle limitations
3d6a201 
This commit adds a note to the documentation saying that ResourceBundle
does not support multiple bundles with the same base name.

Closes spring-projectsgh-27038
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Document ResourceBundle limitations
d1f2646 
This commit adds a note to the documentation saying that ResourceBundle
does not support multiple bundles with the same base name.

Closes spring-projectsgh-27038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Milestone
5.3.9
Development

No branches or pull requests
3 participants
@sbrannen @poutsma @snicoll