Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringBeanAutowiringSupport should log at warn level when autowiring fails #26925

Closed
laoseth opened this issue May 10, 2021 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@laoseth
Copy link

laoseth commented May 10, 2021

I recently upgraded to a newer wildfly version (20-->23) and wildfly now init's webservices very early, before spring initilization is kicked off, so the autowiring in SpringBeanAutowiringSupport fails.

Obviously, that is not a spring issue, but these issues would be WAY easier to find if the failure to wire was at least a Warn level log statement. It appears that the logging in the processInjectionBasedOnCurrentContext method is debug, as it is designed to be called from other places than the constructor itself, but I think there should be a warn or error level log of the failure to wire in the constructor, to lead people to this class when their are external factors that cause this autowire to work differently.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 10, 2021
@jhoeller jhoeller self-assigned this May 10, 2021
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 10, 2021
@jhoeller jhoeller added this to the 5.3.7 milestone May 10, 2021
@jhoeller jhoeller changed the title SpringBeanAutowiringSupport only logs a Debug Message when autowiring fails SpringBeanAutowiringSupport should log at warn level when autowiring fails May 10, 2021
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants