Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect check in AbstractBrokerRegistration's constructor #26896

Closed
tgyurci opened this issue May 5, 2021 · 1 comment
Closed

Incorrect check in AbstractBrokerRegistration's constructor #26896

tgyurci opened this issue May 5, 2021 · 1 comment
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.3.7

Comments

@tgyurci
Copy link

tgyurci commented May 5, 2021

The constructor in org.springframework.messaging.simp.config.AbstractBrokerRegistration checks the non-nullness of the clientOutboundChannel parameter twice but does not check the non-nullness of the clientInboundChannel parameter.

See:

spring-framework/spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractBrokerRegistration.java

Line 48 in 959e6d1

Assert.notNull(clientOutboundChannel, "'clientInboundChannel' must not be null");

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 5, 2021
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 5, 2021
@jhoeller jhoeller added this to the 5.3.7 milestone May 5, 2021
@jhoeller jhoeller self-assigned this May 5, 2021
@jhoeller jhoeller added the for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x label May 5, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x labels May 5, 2021
Closed
@lower-case lower-case mentioned this issue May 9, 2021
Closed
@lower-case

This comment has been minimized.

Sign in to view
jhoeller added a commit that referenced this issue May 11, 2021
@jhoeller
Correct clientInboundChannel assertion (includes constructor javadoc)
9523f1f 
Closes gh-26896
@sync-by-unito sync-by-unito bot mentioned this issue May 12, 2021
Merged
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
@jhoeller @Zoran0104
Correct clientInboundChannel assertion (includes constructor javadoc)
746c5f5 
Closes spring-projectsgh-26896
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@jhoeller @lxbzmy
Correct clientInboundChannel assertion (includes constructor javadoc)
1e7334b 
Closes spring-projectsgh-26896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.3.7
Development

Successfully merging a pull request may close this issue.

Fixes Incorrect Assertion check in AbstractBrokerRegistration lower-case/spring-framework
4 participants
@tgyurci @jhoeller @lower-case @spring-projects-issues