Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level in ExecutorConfigurationSupport.initialize #26810

Closed
rupert-madden-abbott opened this issue Apr 15, 2021 · 1 comment
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@rupert-madden-abbott
Copy link

Please could the level of the logging within ExecutorConfigurationSupport.initialize be reduced to DEBUG?

Currently, this line is always logged at startup but I feel it doesn't convey very useful information and adds noise to the logs by default.

It is also hard to suppress when building on top of this in libraries. My end users often don't know (or care) what this means but I don't want to enforce logging configuration, or a logging implementation on them to hide it.

Happy to raise a PR if this change is agreed!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 15, 2021
@jhoeller jhoeller self-assigned this Apr 15, 2021
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 15, 2021
@jhoeller jhoeller added this to the 5.3.7 milestone Apr 15, 2021
@jhoeller
Copy link
Contributor

Indeed, this isn't particularly useful at info level, same for the shutdown log statement in the same class. I'll take the opportunity to revisit some related logging spots in other components, so no need for a PR from that perspective. (Thanks for volunteering, in any case!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants