Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to correlate ByteBuf leak records to log messages for a specific request #26230

Closed
rstoyanchev opened this issue Dec 7, 2020 · 0 comments
Closed

Ability to correlate ByteBuf leak records to log messages for a specific request #26230

rstoyanchev opened this issue Dec 7, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3.2

Comments

@rstoyanchev
Copy link
Contributor

When Netty's ResourceLeakDetector prints a report about leaked buffers, there is currently no way to match those to log messages for the request where the ByteBuf was created. We can use ByteBuf#touch with the log prefix for the request (based on the channel id) when debug logging is enabled, similar to what Reactor Netty does.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Dec 7, 2020
@rstoyanchev rstoyanchev added this to the 5.3.2 milestone Dec 7, 2020
@rstoyanchev rstoyanchev self-assigned this Dec 7, 2020
@rstoyanchev rstoyanchev added the for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x label Dec 7, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x labels Dec 7, 2020
Closed
@rstoyanchev rstoyanchev removed the status: backported An issue that has been backported to maintenance branches label Dec 7, 2020
rstoyanchev added a commit that referenced this issue Dec 8, 2020
@rstoyanchev
Additional DataBuffer hints
cb44ae6 
See gh-26230
@sync-by-unito sync-by-unito bot mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.2
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues