Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print helpful information in RSocket MetadataExtractor #26130

Closed
rudy2steiner opened this issue Nov 22, 2020 · 2 comments
Closed

Print helpful information in RSocket MetadataExtractor #26130

rudy2steiner opened this issue Nov 22, 2020 · 2 comments
Assignees
@rstoyanchev
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone
5.3.2

Comments

@rudy2steiner
Copy link

rudy2steiner commented Nov 22, 2020 •
edited

Affects: <Since 5.2>

When i try to add extra metadata by RSocketRequester.MetadataSpec#metadata method and don't know i should add
a EntryExtractor. I have no way to get the metadata on server side. And then I found out DefaultMetadataExtractor#extractEntry only can handle WellKnownMimeType.MESSAGE_RSOCKET_ROUTING if we don't register a EntryExtractor for other type mime metadata.
A warn or debug level log should be print if you ignore some of metadata, which can benefit for debugging.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 22, 2020
@rudy2steiner rudy2steiner changed the title Spring message ignore Metadata silently if lack of extractor Spring messaging ignore Metadata silently if lack of extractor Nov 23, 2020
@rstoyanchev rstoyanchev self-assigned this Nov 23, 2020
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 23, 2020
@rstoyanchev rstoyanchev added this to the 5.3.2 milestone Nov 23, 2020
@rstoyanchev
Copy link
Contributor

We can print a debug message about the metadata mime types in the message and the registered ones.

@rstoyanchev rstoyanchev changed the title Spring messaging ignore Metadata silently if lack of extractor Print helpful information RSocket MetadataExtractor Nov 23, 2020
@rstoyanchev rstoyanchev changed the title Print helpful information RSocket MetadataExtractor Print helpful information in RSocket MetadataExtractor Nov 23, 2020
@rudy2steiner
Copy link
Author

@rstoyanchev thanks

@sync-by-unito sync-by-unito bot mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.2
Development

No branches or pull requests
3 participants
@rstoyanchev @rudy2steiner @spring-projects-issues