Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringDecoder does not provide a way to configure the default charset #25762

Closed
damnms opened this issue Sep 13, 2020 · 0 comments
Closed

StringDecoder does not provide a way to configure the default charset #25762

damnms opened this issue Sep 13, 2020 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@damnms
Copy link

damnms commented Sep 13, 2020

i want to write a chatclient for a very old chat system.
that chat system uses iso-8859-1 encoding.
when i use the webclient, german umlaute (äü etc.) are messed up and there is no way to somehow configure that in StringDecoder.
when i tell the webclient to use accept headers with utf8, thats simply ignored as the server can not respond in utf8.

there are 2 or 3 static constructors to allow me to create a StringDecoder but all use utf8!

public static StringDecoder textPlainOnly(List<String> delimiters, boolean stripDelimiter) {
	return new StringDecoder(delimiters, stripDelimiter, new MimeType("text", "plain", DEFAULT_CHARSET));
}

and DEFAULT_CHARSET is UTF-8.

Provide a way to configure that, thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 13, 2020
@rstoyanchev rstoyanchev self-assigned this Sep 14, 2020
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 14, 2020
@rstoyanchev rstoyanchev added this to the 5.2.9 milestone Sep 14, 2020
@rstoyanchev rstoyanchev changed the title StringDecoder can only handle UTF-8 StringDecoder does not provide a way to configure the default charset Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants