Assert preconditions for MergedAnnotations.from() factory methods #25568
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: enhancement
A general enhancement
Milestone
Comments
sbrannen
added
in: core
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this issue
Aug 16, 2020
Prior to this commit, if null values were supplied for the RepeatableContainers or AnnotationFilter arguments to `from()` factory methods in MergedAnnotations, certain operations would eventually result in a NullPointerException. This is to be expected; however, the NullPointerException is often swallowed and only logged at INFO level with an exception message similar to the following. > Failed to introspect annotations on org.example.MyClass: NullPointerException In such cases, the INFO log message is not helpful in diagnosing the problem. Furthermore, since the exception is swallowed, the desired operation (e.g., MergedAnnotations.stream(...)) simply returns no results. This commit improves the user experience by eagerly asserting non-null preconditions for required arguments in MergedAnnotations.from() factory methods. Closes spring-projectsgh-25568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If
nullvalues are supplied for theRepeatableContainersorAnnotationFilterarguments tofrom()factory methods inMergedAnnotations, certain operations will eventually result in aNullPointerException.This is to be expected; however, the
NullPointerExceptionis often swallowed and only logged atINFOlevel with an exception message similar to the following.In such cases, the
INFOlog message is not helpful in diagnosing the problem. Furthermore, since the exception is swallowed, the desired operation (e.g.,MergedAnnotations.stream(...)) simply returns noresults, and the user is left wondering what happened.
The text was updated successfully, but these errors were encountered: