Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide access to AbstractRoutingDataSource's resolved target DataSources #25544

Closed
wilkinsona opened this issue Aug 6, 2020 · 1 comment
Closed

Provide access to AbstractRoutingDataSource's resolved target DataSources #25544

wilkinsona opened this issue Aug 6, 2020 · 1 comment
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone
5.2.9

Comments

@wilkinsona
Copy link
Member

We've had a few Spring Boot issues related to metrics and health where it would be useful to have access to an AbstractRoutingDataSource's resolved targets (spring-projects/spring-boot#22719, spring-projects/spring-boot#22222). Having access to the resolved targets would allow us to automatically provide metrics and health information for the target DataSources without them having to be exposed as beans or without the user having to write so much code to register them for metrics and health manually.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 6, 2020
@wilkinsona wilkinsona mentioned this issue Aug 6, 2020
Closed
@jhoeller jhoeller self-assigned this Aug 6, 2020
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 6, 2020
@jhoeller jhoeller added this to the 5.2.9 milestone Aug 6, 2020
@jhoeller jhoeller changed the title Provide access to an AbstractRoutingDataSource's resolved targets Provide access to AbstractRoutingDataSource's resolved target DataSources Aug 6, 2020
@wilkinsona
Copy link
Member Author

Thank you!

FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@jhoeller
Provide access to AbstractRoutingDataSource's resolved target DataSou…
acfd5ec 
…rces

Closes spring-projectsgh-25544
@sync-by-unito sync-by-unito bot mentioned this issue Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.9
Development

No branches or pull requests
3 participants
@wilkinsona @jhoeller @spring-projects-issues