Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The AbstractTemplateViewResolver class is not abstract #25240

Closed
manueljordan opened this issue Jun 11, 2020 · 3 comments
Closed

The AbstractTemplateViewResolver class is not abstract #25240

manueljordan opened this issue Jun 11, 2020 · 3 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@manueljordan
Copy link

Affects: \5.2.6.RELEASE and minor (since 1.1)


If I see the javadoc of the AbstractTemplateViewResolver class, it indicates:

public class AbstractTemplateViewResolver
extends UrlBasedViewResolver

Abstract base class for template view resolvers, in particular for FreeMarker views.

Well the class really is not abstract how is expected.

Of course it comes from the source code:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 11, 2020
@jhoeller jhoeller self-assigned this Jun 11, 2020
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 11, 2020
@jhoeller jhoeller added this to the 5.2.8 milestone Jun 11, 2020
@jhoeller
Copy link
Contributor

Well spotted! This class is primarily named after AbstractTemplateView (which is actually abstract) but nevertheless does not make sense as a concrete class (so should be declared abstract indeed).

@jhoeller
Copy link
Contributor

It turns out that there are two more such cases: AbstractJCacheConfiguration and AbstractJmxAttribute. I'll fix those along with this issue.

@manueljordan
Copy link
Author

manueljordan commented Jun 11, 2020

No problem, I was doing a tech review for a book and I did realize this situation ... I had the doubt to arise or not this ... and well really is a bug

As usual, huge thanks for your effort in this wonderful framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants