Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc for hibernate5 OpenSessionInViewFilter mentions FlushMode.NEVER #25158

Closed
jiri-pejchal opened this issue May 28, 2020 · 0 comments
Closed

Javadoc for hibernate5 OpenSessionInViewFilter mentions FlushMode.NEVER #25158

jiri-pejchal opened this issue May 28, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Milestone
5.2.7

Comments

@jiri-pejchal
Copy link

Affects: 5.2.6
The javadoc for org.springframework.orm.hibernate5.support.OpenSessionInViewFilter mentions FlushMode.NEVER:

 * <p><b>NOTE</b>: This filter will by default <i>not</i> flush the Hibernate Session,
 * with the flush mode set to {@code FlushMode.NEVER}. It assumes to be used
 * in combination with service layer transactions that care for the flushing: The
 * active transaction manager will temporarily change the flush mode to
 * {@code FlushMode.AUTO} during a read-write transaction, with the flush
 * mode reset to {@code FlushMode.NEVER} at the end of each transaction.

However there is currently no FlushMode.NEVER in org.hibernate.FlushMode, it was removed in hibernate 5.2.
Should there be FlushMode.MANUAL?
@jhoeller jhoeller self-assigned this May 28, 2020
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 28, 2020
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 28, 2020
@jhoeller jhoeller added this to the 5.2.7 milestone May 28, 2020
FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@jhoeller
Consistently refer to FlushMode.MANUAL instead of outdated NEVER
bc0a0a7 
Closes spring-projectsgh-25158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task
Projects
None yet
Milestone
5.2.7
Development

No branches or pull requests
3 participants
@jhoeller @jiri-pejchal @spring-projects-issues