Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultServerRequestBuilder does not respect attributes when building the ServerRequest #25106

Closed
sergiisinelnychenko opened this issue May 19, 2020 · 2 comments
Closed

DefaultServerRequestBuilder does not respect attributes when building the ServerRequest #25106

sergiisinelnychenko opened this issue May 19, 2020 · 2 comments
Assignees
@sbrannen
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.2.7

Comments

@sergiisinelnychenko
Copy link

Affects: <5.2.6>

spring-webflux. The class org.springframework.web.reactive.function.server.DefaultServerRequestBuilder does not respect attributes when building the org.springframework.web.reactive.function.server.ServerRequest.
When you use
ServerRequest.from(initialRequest) .attribute("somename", "somevalue") .build();

  • the resulting ServerRequest does not have the attribute specified. Could be easily tracked by source code
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 19, 2020
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels May 19, 2020
@sbrannen sbrannen self-assigned this May 19, 2020
@sbrannen sbrannen added this to the 5.2.7 milestone May 19, 2020
@sbrannen sbrannen added the for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x label May 19, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x labels May 19, 2020
Closed
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label May 19, 2020
@sbrannen
Copy link
Member

sbrannen commented May 19, 2020 •
edited

Indeed, the attributes are not available in the ServerWebExchange that backs the request.

Thanks for pointing this out.

sbrannen added a commit to sbrannen/spring-framework that referenced this issue May 19, 2020
@sbrannen
Include attributes in request built by DefaultServerRequestBuilder
d0b2299 
Closes spring-projectsgh-25106
sbrannen added a commit to sbrannen/spring-framework that referenced this issue May 20, 2020
@sbrannen
Include attributes in request built by DefaultServerRequestBuilder
3ff979f 
Closes spring-projectsgh-25106
sbrannen added a commit to sbrannen/spring-framework that referenced this issue May 20, 2020
@sbrannen
Honor attributes configured in ServerRequest.from() builder
2bb2f90 
Prior to this commit, if attributes were configured in the builder
returned by `ServerRequest.from(...)`, those attributes were not
available in the `ServerRequest` built by the builder. In addition, any
attributes in the original `ServerRequest` supplied to
`ServerRequest.from(...)` were also ignored.

This commit addresses this issue by ensuring that the attributes
configured via DefaultServerRequestBuilder are used as the attributes
in the resulting `ServerRequest`.

This commit also polishes the Javadoc in `ServerRequest` and
`ClientResponse` and avoids the use of lambda expressions in the
constructors for `DefaultServerRequestBuilder` and
`DefaultClientResponseBuilder`.

Closes spring-projectsgh-25106
sbrannen added a commit that referenced this issue May 21, 2020
@sbrannen
Honor attributes configured in ServerRequest.from() builder
5c04c96 
Prior to this commit, if attributes were configured in the builder
returned by `ServerRequest.from(...)`, those attributes were not
available in the `ServerRequest` built by the builder. In addition, any
attributes in the original `ServerRequest` supplied to
`ServerRequest.from(...)` were also ignored.

This commit addresses this issue by ensuring that the attributes
configured via DefaultServerRequestBuilder are used as the attributes
in the resulting `ServerRequest`.

This commit also polishes the Javadoc in `ServerRequest` and
`ClientResponse` and avoids the use of lambda expressions in the
constructors for `DefaultServerRequestBuilder` and
`DefaultClientResponseBuilder`.

Closes gh-25106
@sbrannen
Copy link
Member

This has been fixed in 5.1.16, 5.2.7, and 5.3 M1.

Feel free to try it out in the latest snapshots for those branches.

FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@sbrannen
Honor attributes configured in ServerRequest.from() builder
e067438 
Prior to this commit, if attributes were configured in the builder
returned by `ServerRequest.from(...)`, those attributes were not
available in the `ServerRequest` built by the builder. In addition, any
attributes in the original `ServerRequest` supplied to
`ServerRequest.from(...)` were also ignored.

This commit addresses this issue by ensuring that the attributes
configured via DefaultServerRequestBuilder are used as the attributes
in the resulting `ServerRequest`.

This commit also polishes the Javadoc in `ServerRequest` and
`ClientResponse` and avoids the use of lambda expressions in the
constructors for `DefaultServerRequestBuilder` and
`DefaultClientResponseBuilder`.

Closes spring-projectsgh-25106
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022
@sbrannen @zx20110729
Honor attributes configured in ServerRequest.from() builder
3bc5894 
Prior to this commit, if attributes were configured in the builder
returned by `ServerRequest.from(...)`, those attributes were not
available in the `ServerRequest` built by the builder. In addition, any
attributes in the original `ServerRequest` supplied to
`ServerRequest.from(...)` were also ignored.

This commit addresses this issue by ensuring that the attributes
configured via DefaultServerRequestBuilder are used as the attributes
in the resulting `ServerRequest`.

This commit also polishes the Javadoc in `ServerRequest` and
`ClientResponse` and avoids the use of lambda expressions in the
constructors for `DefaultServerRequestBuilder` and
`DefaultClientResponseBuilder`.

Closes spring-projectsgh-25106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.2.7
Development

No branches or pull requests
3 participants
@sbrannen @sergiisinelnychenko @spring-projects-issues