Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing null checks in AbstractMessageChannel.addInterceptor #25089

Closed
spring-projects-issues opened this issue May 16, 2020 · 2 comments
Closed

Missing null checks in AbstractMessageChannel.addInterceptor #25089

spring-projects-issues opened this issue May 16, 2020 · 2 comments
Assignees
@jhoeller
Labels
in: messaging Issues in messaging modules (jms, messaging) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.1.16

Comments

@spring-projects-issues
Copy link
Collaborator

Backport of gh-25088
@spring-projects-issues spring-projects-issues added in: messaging Issues in messaging modules (jms, messaging) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels May 16, 2020
@spring-projects-issues spring-projects-issues added this to the 5.1.16 milestone May 16, 2020
@jhoeller jhoeller self-assigned this May 16, 2020
@jhoeller jhoeller changed the title Missing null checks in AbstractMessageChannel.addInterceptor/setInterceptors Missing null checks in AbstractMessageChannel.addInterceptor May 18, 2020
@jhoeller
Copy link
Contributor

Since we don't generally assert against null in Collection arguments in 5.1.x, not even in RestTemplate, not even having a convenience method for it in Assert, I opted for making it consistent with that line through simply adding assertions to the addInterceptor methods.

jhoeller added a commit that referenced this issue May 18, 2020
@jhoeller
Consistent not-null assertions for configured interceptors
4ec02a7 
Closes gh-25089
@spring-projects-issues
Copy link
Collaborator Author

Fixed via 4ec02a7

jhoeller added a commit that referenced this issue Jun 10, 2020
@jhoeller
Consistent not-null assertions for configured interceptors
f4d33a6 
Closes gh-25089
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jun 10, 2020
@jhoeller jhoeller removed the status: backported An issue that has been backported to maintenance branches label Jun 10, 2020
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022
@jhoeller @zx20110729
Consistent not-null assertions for configured interceptors
e1e9f2d 
Closes spring-projectsgh-25089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: messaging Issues in messaging modules (jms, messaging) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.16
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues