New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpHeaders equals may return false without comparing actual content #25034
Comments
Let's backport this to 5.1.x as well then, given that it dates back to a 5.1 change... and that the |
This is a binary incompatible change that breaks Spring REST docs, can we please reconsider it?
|
It seems that the accepted argument got relaxed from We need to change the signature back to the original in 5.2.x and 5.1.x. I've got a few other things to backport as well, so I'll take care of it. |
In 5.1
HttpHeaders
became aMultiValueMap
and it became possible to wrap existingHttpHeaders
instances rather than copy their contents. As a result it's possible to have multipleHttpHeaders
wrappers around the actualMultiValueMap
content.The
equals
method tries to compare theMultiValueMap
content by nesting on theheaders
field but if the levels of nesting are uneven, it may return false. For example:The text was updated successfully, but these errors were encountered: