Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of ContentDisposition fixes to HttpHeaders #24580

Closed
rstoyanchev opened this issue Feb 24, 2020 · 1 comment
Closed

Backport of ContentDisposition fixes to HttpHeaders #24580

rstoyanchev opened this issue Feb 24, 2020 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
4.3.27

Comments

@rstoyanchev
Copy link
Contributor

ContentDisposition was created in 5.0, supporting all Content-Disposition types including "form-data", "inline" and "attachment" for use in client and server scenarios. Prior to that, HttpHeaders did have support for Content-Disposition of type "form-data", for use in client scenarios with the RestTemplate. This ticket is to review fixes in ContentDisposition that may be worth backporting to HttpHeaders in the 4.3.x branch for consistency.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Feb 24, 2020
@rstoyanchev rstoyanchev added this to the 4.3.27 milestone Feb 24, 2020
@rstoyanchev rstoyanchev self-assigned this Feb 24, 2020
rstoyanchev added a commit that referenced this issue Apr 21, 2020
@rstoyanchev
Escape quoted filename in HttpHeaders
85c5a0c 
This is primarily to align with similar changes applied to
ContentDisposition in 5.x.

Closes gh-24580
@spring-projects-issues
Copy link
Collaborator

Fixed via 85c5a0c

@skitt skitt mentioned this issue May 14, 2020
Merged
@RockyMM RockyMM mentioned this issue Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
4.3.27
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues