Skip to content

Raise log level for exceptions from EntityManager close call #24501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mirkoadebahr opened this issue Feb 11, 2020 · 0 comments
Closed

Raise log level for exceptions from EntityManager close call #24501

mirkoadebahr opened this issue Feb 11, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.4

Comments

@mirkoadebahr
Copy link

Version 5.1.9

In EntityManagerFactoryUtils::closeEntityManager there is a catch-all for Throwable which logs any exception on DEBUG level. It would be very helpful if the level could be increased to ERROR. In our multi-tenancy project we're using a custom ConnectionProvider which threw an exception, but we didn't see it in the logs and it took us a day to track down the problem.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 11, 2020
@jhoeller jhoeller changed the title Exceptions are logged on debug when closing EntityManager Raise log level for exceptions from EntityManager close call Feb 11, 2020
@jhoeller jhoeller self-assigned this Feb 11, 2020
@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 11, 2020
@jhoeller jhoeller added this to the 5.2.4 milestone Feb 11, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Feb 12, 2020
Closed
jhoeller added a commit that referenced this issue Feb 12, 2020
@jhoeller
Raise log level for exceptions from EntityManager close call
d12619c 
Closes gh-24501
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.4
Development

No branches or pull requests
3 participants
@jhoeller @spring-projects-issues @mirkoadebahr