Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JDK 14 #24453

Closed
jhoeller opened this issue Jan 29, 2020 · 4 comments
Closed

Compatibility with JDK 14 #24453

jhoeller opened this issue Jan 29, 2020 · 4 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

With JDK 14 GA coming up in March and the final release candidate just in time for our Spring Framework 5.2.4 release, let's aim for general runtime compatibility as well as being able to run the Spring Framework master build on JDK 14. If there are any limitations, e.g. with JDK 14 bytecode level in certain scenarios, those should get documented.

@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jan 29, 2020
@jhoeller jhoeller added this to the 5.2.4 milestone Jan 29, 2020
@jhoeller jhoeller self-assigned this Jan 29, 2020
@dreis2211
Copy link
Contributor

Gradle doesn't support JDK 14 yet: see gradle/gradle#10248

@sbrannen sbrannen self-assigned this Feb 3, 2020
@sbrannen sbrannen removed their assignment Feb 3, 2020
@jhoeller
Copy link
Contributor Author

jhoeller commented Feb 5, 2020

A Groovy 3.0 upgrade seems to be necessary for full JDK 14 compatibility but since it's just at 3.0 RC3 at the moment, we'll probably only apply the upgrade to our build in the Spring Framework 5.3 timeframe. It's binary compatible anyway, so applications can choose to upgrade to Groovy 3.0 on their own.

@jhoeller
Copy link
Contributor Author

jhoeller commented Feb 6, 2020

Looks like everything is ready for JDK 14 on our end, except for the Groovy version issue in our build. We might need a test runtime override for the time being there, or possibly a full Groovy 3.0 upgrade for our build as long as we can guarantee binary compatibility with Groovy 2.5.9 at runtime.

@jhoeller
Copy link
Contributor Author

jhoeller commented Feb 6, 2020

As per #24474, we automatically switch to Groovy 3.0 in case of a customJavaHome specified for the build, allowing our new JDK 14 CI build to pass without modifications. Since no known issues remain for the time being, we are ready to claim JDK 14 compatibility as of the upcoming Spring Framework 5.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants