Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing default Smile codec via CodecConfigurer #24382

Closed
eftche opened this issue Jan 16, 2020 · 0 comments
Closed

Allow customizing default Smile codec via CodecConfigurer #24382

eftche opened this issue Jan 16, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2.4

Comments

@eftche
Copy link

eftche commented Jan 16, 2020 •
edited

Affects: 5.1.12

Even though Smile codec is configured as part of default codecs in BaseDefaultCodecs, there's currently no way to configure it or replace it similar to other default codecs.
The only way arount at the moment is to remove all defaults and reconfigure everything from scratch using only custom codecs.
It seems to be even more complicated on the client side where default codecs include specials for SSE and multipart, so unregistering all defaults and building it all back is quite cumbersome.

This is inconsistent with other defaults, but also the whole codec configuration system seems very inconvenient for simple tasks like disabling a particular codec feature (in my case to get around #24198) or more frequent customizations like adding modules or mixins to ObjectMapper.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 16, 2020
@rstoyanchev rstoyanchev self-assigned this Jan 17, 2020
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 17, 2020
@rstoyanchev rstoyanchev added this to the 5.2.4 milestone Jan 17, 2020
@rstoyanchev rstoyanchev changed the title There's no way to customize default Smile codec Allow customizing default Smile codec via CodecConfigurer Jan 17, 2020
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.4
Development

No branches or pull requests
3 participants
@eftche @rstoyanchev @spring-projects-issues