Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aysnc request cors Interceptor will repeat set Vary header #24222

Closed
blackstorm opened this issue Dec 18, 2019 · 2 comments
Closed

Aysnc request cors Interceptor will repeat set Vary header #24222

blackstorm opened this issue Dec 18, 2019 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@blackstorm
Copy link

version 2.2.2

example

WebMvcConfigurer

CorsRegistration corsRegistration = registry.addMapping("/**")
                .allowCredentials(true);
corsRegistration.allowedHeaders("*")
                .maxAge(1800L)
                .allowedMethods(HttpMethod.GET.name(),
                        HttpMethod.POST.name(),
                        HttpMethod.PUT.name(),
                        HttpMethod.OPTIONS.name(),
                        HttpMethod.DELETE.name())
                .exposedHeaders("Content-Length");

controller

@RequestMapping("/test)
@RestController
public class ExampleController {
    @GetMapping
    public CompletableFuture<T> test() {
        // do something
    }
}

reponse headers

Vary | Origin
Vary | Access-Control-Request-Method
Vary | Access-Control-Request-Headers
Vary | Origin
Vary | Access-Control-Request-Method
Vary | Access-Control-Request-Headers
@snicoll snicoll transferred this issue from spring-projects/spring-boot Dec 18, 2019
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2019
@blackstorm
Copy link
Author

#24223 PR

@rstoyanchev
Copy link
Contributor

Superseded by #24223.

For future reference you do not need to create both an issue and a PR. Just create the PR with the issue description.

@rstoyanchev rstoyanchev added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants