Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: annotation searches no longer handle exceptions #24188

Closed
1 task done
sbrannen opened this issue Dec 11, 2019 · 0 comments
Closed
1 task done

Regression: annotation searches no longer handle exceptions #24188

sbrannen opened this issue Dec 11, 2019 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Milestone
5.2.3

Comments

@sbrannen
Copy link
Member

sbrannen commented Dec 11, 2019 •
edited

Overview

While working on #24136, it became apparent that the use of AnnotationUtils.handleIntrospectionFailure() was removed in b91ccf0 and added back as a private method in 37255af.

Consequently, we lost that exception handling support outside of AnnotationUtils which will inevitably lead to regressions for some use cases.

Potential Candidates

Potential candidates in AnnotationsScanner for local exception handling.

  • processElement()
  • processClassInheritedAnnotations()
  • processClassHierarchy()
  • processMethodInheritedAnnotations()
  • processMethodHierarchy()

Deliverables

  • Start using AnnotationUtils.handleIntrospectionFailure() within the new MergedAnnotation internals.
@sbrannen sbrannen added type: regression A bug that is also a regression in: core Issues in core modules (aop, beans, core, context, expression) labels Dec 11, 2019
@sbrannen sbrannen added this to the 5.2.3 milestone Dec 11, 2019
@sbrannen sbrannen mentioned this issue Dec 11, 2019
Closed
@sbrannen sbrannen self-assigned this Dec 11, 2019
sbrannen added a commit that referenced this issue Dec 11, 2019
@sbrannen
Handle exceptions in annotation searches again
6a354e0 
Closes gh-24188
sbrannen added a commit that referenced this issue Dec 12, 2019
@sbrannen
Handle exceptions in annotation searches again
f948f1e 
Prior to Spring Framework 5.2, most annotation search algorithms made
use of AnnotationUtils.handleIntrospectionFailure() to handle exceptions
thrown while attempting to introspect annotation metadata. With the
introduction of the new MergedAnnotation API in Spring Framework 5.2,
this exception handling was accidentally removed.

This commit introduces the use of handleIntrospectionFailure() within
the new MergedAnnotation internals in order to (hopefully) align with
the previous behavior.

Closes gh-24188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.2.3
Development

No branches or pull requests
1 participant
@sbrannen