Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Kotlin DSL class constructors internal #24059

Closed
sdeleuze opened this issue Nov 22, 2019 · 0 comments
Closed

Make Kotlin DSL class constructors internal #24059

sdeleuze opened this issue Nov 22, 2019 · 0 comments
Assignees
@sdeleuze
Labels
type: task A general task
Milestone
5.2.2

Comments

@sdeleuze
Copy link
Contributor

Kotlin DSL are intended to be used via builder functions like router { }, coRouter { }, beans {} or extensions like mockMvc.get(), not via classes constructor like RouterFunctionDsl(). #23758 is a good example where we need to change constructor API.

This issue intend to make classes constructor like RouterFunctionDsl() internal, in order to allow only usage via builder and extension functions.
@sdeleuze sdeleuze added the type: task A general task label Nov 22, 2019
@sdeleuze sdeleuze added this to the 5.2.2 milestone Nov 22, 2019
@sdeleuze sdeleuze self-assigned this Nov 22, 2019
sdeleuze added a commit to spring-projects-experimental/spring-fu that referenced this issue Nov 22, 2019
@sdeleuze
Use beans builder function instead of BeanDefinitionDsl constructor
00845b7 
See spring-projects/spring-framework#24059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
type: task A general task
Projects
None yet
Milestone
5.2.2
Development

No branches or pull requests
1 participant
@sdeleuze