Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid substring allocation in StringUtils.replace #24023

Closed
jhoeller opened this issue Nov 19, 2019 · 0 comments
Closed

Avoid substring allocation in StringUtils.replace #24023

jhoeller opened this issue Nov 19, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.2

Comments

@jhoeller
Copy link
Contributor

Our heavily used StringUtils.replace implementation temporarily allocates String instances from String.substring calls which can easily be avoided by using the corresponding StringBuilder.append variants.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 19, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 19, 2019
@jhoeller jhoeller self-assigned this Nov 19, 2019
@jhoeller jhoeller added the for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x label Nov 19, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x labels Nov 19, 2019
Closed
Closed
Closed
jhoeller added a commit that referenced this issue Nov 19, 2019
@jhoeller
Avoid substring allocation in StringUtils.replace
268d029 
Closes gh-24023
jhoeller added a commit that referenced this issue Nov 19, 2019
@jhoeller
Avoid substring allocation in StringUtils.replace
2a63147 
Closes gh-24023
jhoeller added a commit that referenced this issue Nov 19, 2019
@jhoeller
Avoid substring allocation in StringUtils.replace
ee2fe1d 
Closes gh-24023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues