Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align implementations of StringToUUIDConverter and UUIDEditor #23940

Closed
2 tasks done
sbrannen opened this issue Nov 6, 2019 · 0 comments
Closed
2 tasks done

Align implementations of StringToUUIDConverter and UUIDEditor #23940

sbrannen opened this issue Nov 6, 2019 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2.2

Comments

@sbrannen
Copy link
Member

sbrannen commented Nov 6, 2019 •
edited

Overview

UUIDEditor checks if the supplied value hasText; whereas, StringToUUIDConverter checks if the supplied value hasLength. Similarly, StringToUUIDConverter trims the supplied value, but UUIDEditor does not.

Deliverables

  • Switch to StringUtils.hasText in StringToUUIDConverter to align with the behavior of UUIDEditor.
  • Use String#trim() in UUIDEditor to align with the behavior of StringToUUIDConverter.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 6, 2019
@sbrannen sbrannen self-assigned this Nov 6, 2019
@sbrannen sbrannen added this to the 5.2.2 milestone Nov 6, 2019
@sbrannen sbrannen changed the title Align empty value semantics of StringToUUIDConverter with UUIDEditor Align implementations of StringToUUIDConverter and UUIDEditor Nov 6, 2019
@sbrannen sbrannen mentioned this issue Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.2
Development

No branches or pull requests
1 participant
@sbrannen