Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM has explicit compile scope for each dependency #23660

Closed
snicoll opened this issue Sep 18, 2019 · 1 comment
Closed

BOM has explicit compile scope for each dependency #23660

snicoll opened this issue Sep 18, 2019 · 1 comment
Labels
type: regression A bug that is also a regression
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Sep 18, 2019

As a result, spring-test is put on the compile scope in any application that uses the BOM (and includes spring-test transitively).

See https://repo.spring.io/snapshot/org/springframework/spring-framework-bom/5.2.0.BUILD-SNAPSHOT/spring-framework-bom-5.2.0.BUILD-20190918.123055-142.pom

@snicoll snicoll added the type: regression A bug that is also a regression label Sep 18, 2019
@snicoll snicoll added this to the 5.2 GA milestone Sep 18, 2019
@bclozel
Copy link
Member

bclozel commented Sep 18, 2019

Ooops, sorry.
I've compared former and new BOMs and here are the differences:

  • the link to the project page has been updated
  • the scope information present in 5.2.0 SNAPSHOTs
  • obviously, versions aren't the same

I've just pushed a workaround for that, removing the scope information from the BOM before publication.

Looking at Gradle, I haven't found an issue about that, and I've only found a couple of places where POMs are generated and it seems that the scope information is always written in dependency management sections.

Since Gradle dependencies are always declared in a configuration, I guess this is only a problem with maven consumers. I don't know about best practices in this domain, especially whether or not BOMs should be allowed to publish dependency management with scopes, nor what should be the default.

Could you check that and maybe get in touch with the Gradle team if you think this could be an improvement in Gradle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A bug that is also a regression
Projects
None yet
Development

No branches or pull requests

2 participants