Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ClassFilter and MethodMatcher implementations are cacheable #23659

Closed
12 tasks done
sbrannen opened this issue Sep 18, 2019 · 0 comments
Closed
12 tasks done

Ensure ClassFilter and MethodMatcher implementations are cacheable #23659

sbrannen opened this issue Sep 18, 2019 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone
5.1.10

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 18, 2019 •
edited

Overview

While resolving the regression raised in #23571, it came to our attention that not all of our ClassFilter and MethodMatcher implementations are properly cacheable with CGLIB generated proxies due to missing (or improper) equals() and hashCode() implementations.

Although such deficiencies may not manifest themselves as bugs in Core Spring's default arrangements, these might cause issues in custom arrangements in user applications.

Already Implemented

  • AnnotationClassFilter
  • AspectJExpressionPointcut
  • DefaultIntroductionAdvisor and LockMixinAdvisor
  • DeclareParentsAdvisor - lambda expression in constructor: unnecessary
  • TrueClassFilter: unnecessary due to Singleton pattern
  • TrueMethodMatcher: unnecessary due to Singleton pattern
  • AbstractRegexpMethodPointcut and JdkRegexpMethodPointcut
  • CacheOperationSourcePointcut
  • JCacheOperationSourcePointcut
  • PerTargetInstantiationModelPointcut: unnecessary
  • TransactionAttributeSourcePointcut

Deliverables

Ensure that ClassFilter and MethodMatcher implementations properly implement equals(), hashCode(), and toString().

Potential Bugs

  • RootClassFilter: equals(), hashCode(), and toString()
  • TypePatternClassFilter: equals(), hashCode(), and toString()
  • AnnotationMethodMatcher: equals() does not include the checkInherited flag

Improvements

  • ControlFlowPointcut: toString()
  • UnionClassFilter: toString()
  • IntersectionClassFilter: toString()
  • IntersectionMethodMatcher and IntersectionIntroductionAwareMethodMatcher: toString()
  • UnionMethodMatcher and UnionIntroductionAwareMethodMatcher: toString()
  • AdviceExcludingMethodMatcher: toString()
  • SetterPointcut and GetterPointcut: toString()
  • NameMatchMethodPointcut: toString()
  • ClassFilterAwareUnionMethodMatcher and ClassFilterAwareUnionIntroductionAwareMethodMatcher: toString()
@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Sep 18, 2019
@sbrannen sbrannen added this to the 5.1.10 milestone Sep 18, 2019
@sbrannen sbrannen self-assigned this Sep 18, 2019
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 18, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
550bb1e 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 18, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
1342266 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 18, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
7f5c88c 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 18, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
d826bfc 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 18, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
db4f386 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 19, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
23e4367 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 19, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
3758035 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 19, 2019
@sbrannen
[WIP] Ensure ClassFilter and MethodMatcher implementations are cacheable
470b20c 
See spring-projectsgh-23659
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 19, 2019
@sbrannen
Ensure ClassFilter and MethodMatcher implementations are cacheable
4a3e9ee 
While resolving the regression raised in spring-projectsgh-23571, it came to our
attention that not all of our ClassFilter and MethodMatcher
implementations were properly cacheable with CGLIB generated proxies
due to missing (or improper) equals() and hashCode() implementations.

Although such deficiencies may not manifest themselves as bugs in Core
Spring's default arrangements, these might cause issues in custom
arrangements in user applications.

This commit addresses this by ensuring that ClassFilter and
MethodMatcher implementations properly implement equals() and
hashCode(). In addition, missing toString() implementations have been
added to improve diagnostics for logging and debugging.

Closes spring-projectsgh-23659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
5.1.10
Development

No branches or pull requests
1 participant
@sbrannen