Document minimum JDK 8 update version

[crosslover]

• surefire: 2.20.1
• jdk: 1.8.0_45
• Spring: 5.0.15.RELEASE
• mvn: 3.6.1

When I run mvn test with the maven-surefire-plugin, this happens:

[2019-09-02T09:28:48.807Z] java.lang.IllegalStateException: Failed to load ApplicationContext

[2019-09-02T09:28:48.807Z] Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'requestMappingHandlerAdapter' defined in class path resource [org/springframework/web/servlet/config/annotation/DelegatingWebMvcConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter]: Factory method 'requestMappingHandlerAdapter' threw exception; nested exception is java.lang.BootstrapMethodError: call site initialization exception

[2019-09-02T09:28:48.807Z] Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter]: Factory method 'requestMappingHandlerAdapter' threw exception; nested exception is java.lang.BootstrapMethodError: call site initialization exception

[2019-09-02T09:28:48.807Z] Caused by: java.lang.BootstrapMethodError: call site initialization exception

[2019-09-02T09:28:48.807Z] Caused by: java.lang.ClassCastException: Cannot cast org.springframework.http.converter.xml.SourceHttpMessageConverter$$Lambda$81/217380081 to org.xml.sax.EntityResolver

mvn clean test -U -X -T 4

the error code slice:

public class SourceHttpMessageConverter<T extends Source> extends AbstractHttpMessageConverter<T> {

	private static final EntityResolver NO_OP_ENTITY_RESOLVER =
			(publicId, systemId) -> new InputSource(new StringReader(""));

However, when I used the jdk of version jdk1.8.0_211, it didn't happen any more. It probably could be caused by jdk type inference mechanism(which may be fixed in later version) under the surefire class loader.

Just report the issue, btw are there some documents related to it?

[sbrannen]

This sounds to me like a bug in the compiler that generated inappropriate byte code.

Upgrading your JDK is the correct solution.

I seem to recall that we used to recommend JDK 1.8.0 update 60 or higher, but I can't find any documentation spelling that out at the moment.

Our Upgrading to Version 5.0 wiki page simply states the following without mentioning a specific minimum update version.

Spring Framework 5.0 requires JDK 8 (Java SE 8) or above

The same is true for the reference manual:

As of Spring Framework 5.1, Spring requires JDK 8+ (Java SE 8+) and provides out-of-the-box support for JDK 11 LTS.

@sdeleuze pointed out that we have an outdated recommendation here:

spring-framework/src/docs/asciidoc/web/webmvc-view.adoc

Line 798 in 0d3fb0e

React running on Nashorn. In that case, Java 8u60 or greater is required, due

---

Perhaps we should consider mentioning a recommended minimum update version for use with Spring.

[sbrannen]

Team Decision: document that JDK 1.8 update 60 is suggested as the minimum patch release for Java 8 but mention that it is generally recommended to use a recent patch release.

[sbrannen]

Deliverables

Update the following documentation.

• Build from Source (Wiki)
• Upgrading to Version 5.0 (Wiki)
• Overview (Reference Manual)
• webmvc-view.adoc (Reference Manual)
• webflux-view.adoc same as in webmvc-view.adoc (Reference Manual)