Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parity between Java and Kotlin router DSL #23524

Closed
sdeleuze opened this issue Aug 27, 2019 · 1 comment
Closed

Improve parity between Java and Kotlin router DSL #23524

sdeleuze opened this issue Aug 27, 2019 · 1 comment
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2 GA

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Aug 27, 2019 •
edited

Add variants with pattern, predicate and handlerFunction to Kotlin router DSLs.
Equivalent of Builder GET(String pattern, RequestPredicate predicate, HandlerFunction<ServerResponse> handlerFunction); in Java.
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Aug 27, 2019
@sdeleuze sdeleuze added this to the 5.2 RC2 milestone Aug 27, 2019
@sdeleuze sdeleuze self-assigned this Aug 27, 2019
@jhoeller jhoeller changed the title Add variants with pattern, predicate and handlerFunction to Kotlin routter DSLs Add variants with pattern, predicate and handlerFunction to Kotlin router DSLs Sep 2, 2019
@sdeleuze sdeleuze modified the milestones: 5.2 RC2, 5.2 GA Sep 4, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 16, 2019
@sdeleuze
Add variants with pattern + predicate to Kotlin router DSLs
8500a88 
Closes spring-projectsgh-23524
@sdeleuze sdeleuze changed the title Add variants with pattern, predicate and handlerFunction to Kotlin router DSLs Improve parity between Java and Kotlin router DSL Sep 16, 2019
@sdeleuze sdeleuze reopened this Sep 17, 2019
@sdeleuze
Copy link
Contributor Author

Merging #23526 in that one: Kotlin DSLs should contain add, filter, before, after and onError.

@sdeleuze sdeleuze mentioned this issue Sep 17, 2019
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 17, 2019
@sdeleuze
Improve parity between Java and Kotlin router DSL
11a7ce5 
This commit adds following functions to the Kotlin DSL:
add, filter, before, after and onError.

Closes spring-projectsgh-23524
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 17, 2019
@sdeleuze
Improve parity between Java and Kotlin router DSL
6600e2b 
This commit adds following functions to the Kotlin DSL:
add, filter, before, after and onError.

Closes spring-projectsgh-23524
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 17, 2019
@sdeleuze
Improve parity between Java and Kotlin router DSL
007940f 
This commit adds following functions to the Kotlin DSL:
add, filter, before, after and onError.

Closes spring-projectsgh-23524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 GA
Development

No branches or pull requests
1 participant
@sdeleuze